rnk accepted this revision.
rnk added a comment.

Please avoid the extra enum case, and commit.



================
Comment at: include/clang/Basic/TargetInfo.h:1223
   enum CallingConvKind {
     CCK_Default,
----------------
This is poorly named. I'll try to send a patch to rename it after this lands.


================
Comment at: include/clang/Basic/TargetInfo.h:1226-1227
     CCK_ClangABI4OrPS4,
-    CCK_MicrosoftX86_64
+    CCK_MicrosoftX86_64,
+    CCK_MicrosoftARM64
   };
----------------
IMO it'd be better to collapse these into something like `CCK_MicrosoftWin64`, 
since we don't treat them differently.


Repository:
  rC Clang

https://reviews.llvm.org/D49770



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to