rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

What I requested was that either we make `CastExpr::isPartOfExplicitCast()` 
return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move 
`isPartOfExplicitCast` do the `ImplicitCastExpr` derived class. We don't need 
to do both, and since we're doing the latter in 
https://reviews.llvm.org/D49838, we don't need to do anything else. 
(Essentially, my request was to fix the bug that 
`CastExpr::isPartOfExplicitCast()` incorrectly returned `false` when called on 
an explicit cast expression, and I don't mind which way we fix it.)


Repository:
  rC Clang

https://reviews.llvm.org/D49844



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to