rupprecht added a comment. In https://reviews.llvm.org/D49927#1178659, @ldionne wrote:
> Just to make sure I understand properly: this means we will use newlib's > implementation of `iswcntrl_l` & friends instead of our own emulation (which > is an ODR violation currently going unnoticed)? And this is OK because newlib > provides `iswcntrl_l` & friends starting at version 2.4. Yes, that's correct. I clarified the description: when the methods were added, the tree was configured with NEWLIB_MINOR_VERSION = 4, meaning this wasn't released until the next version, newlib 2.5. > This is my understanding. If it is correct, then LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D49927 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
