Good grief... I even made a note to remove this 'TODO' on my whiteboard! I discussed the name with AaronBallman who preferred ParsedAttr over ParsedAttribute (since ParsedAttributes is also a type).
Fixed in r339039. -----Original Message----- From: meiners...@googlemail.com [mailto:meiners...@googlemail.com] On Behalf Of Michael Kruse Sent: Monday, August 6, 2018 11:00 AM To: Keane, Erich <erich.ke...@intel.com> Cc: cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r337005 - [NFC] Rename clang::AttributeList to clang::ParsedAttr 2018-07-13 10:07 GMT-05:00 Erich Keane via cfe-commits <cfe-commits@lists.llvm.org>: > -class AttributeList { // TODO: This should really be called ParsedAttribute > +class ParsedAttr { // TODO: This should really be called ParsedAttribute Should this TODO be removed/ParsedAttr really be called ParsedAttribute? Michael _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
