ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with a few NITs

Comment at: clangd/CodeComplete.cpp:687
+struct ScoredSignatureGreater {
+  bool operator()(const ScoredSignature &L, const ScoredSignature &R) {
+    // Ordering follows:
NIT: Maybe make it a function with a descriptive name, e.g. 
We could call it in a lambda, should make the code even clearer.

Comment at: clangd/CodeComplete.cpp:755
+              ScoredSignatureGreater());
+    for (const auto &SS : ScoredSignatures) {
+      SigHelp.signatures.push_back(SS.second);
NIT: remove braces around the single-statement loop body

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to