rjmccall added a comment.

Oh, I missed that there was a separate review for this.  A lot of the important 
subclasses that need extra storage have been designed with the expectation that 
these bit-fields fit within 32 bits.  For example, `FunctionType` starts with a 
bunch of bit-fields because the expectation is that they'll fit into the 
tail-padding of `Type`.  So this assertion should really be testing <= 4, and 
if we need to land a few patches first to make that true, we should do so.


Repository:
  rC Clang

https://reviews.llvm.org/D50630



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to