ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM. Many thanks for fixing this. Adding some failure monitoring seems like a nice idea. On the other hand, polluting every test with stderr redirection doesn't look like a nice idea. As a middle ground, I could imagine some extra checking being done if `-lit-test` is passed, e.g. returning a non-zero error code on request parsing errors would trigger test failures in these particular cases, right? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
