rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

This doesn't seem necessary. `NewAlign` specifies the alignment beyond which 
types acquire "new-extended alignment" per the C++ standard, or equivalently 
the alignment beyond which we need to pass an `align_val_t` argument to 
`operator new`.

If all types of size <= 8 are provided with sufficiently-aligned storage (which 
8 byte alignment definitely is), then they are irrelevant for the computation 
of this value, because `new T` for such a type never needs to pass an 
alignment. (A similar argument applies for the array-new case.)


Repository:
  rC Clang

https://reviews.llvm.org/D50683



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D50683: [... Pirama Arumuga Nainar via Phabricator via cfe-commits
    • [PATCH] D506... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D506... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D506... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D506... Pirama Arumuga Nainar via Phabricator via cfe-commits

Reply via email to