ioeric added inline comments.
================
Comment at: clangd/CodeCompletionStrings.cpp:52
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
----------------
ilya-biryukov wrote:
> ioeric wrote:
> > `RK_Pattern` can also have declaration. Do we want to consider those?
> See the FIXME at the top, we don't have the API exposed from clang to get the
> proper declarations (IIRC, this only shows up for ObjC properties and we need
> to look at both getters and setters when looking for a comment, and the clang
> code does not expose the API to do that).
>
> We should probably fix this, but that's a separate issue.
`getDeclaration()` has started supporting `RK_Pattern` recently, so this should
be fixable now. But feel free to leave it to future.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50726
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
