kadircet added inline comments.
================
Comment at: clangd/ClangdLSPServer.cpp:75
+std::string NormalizeRequestID(const json::Value &ID) {
+ CancelParams CP;
+ fromJSON(json::Object{{"id", ID}}, CP);
----------------
ioeric wrote:
> Use `ID.getAsString()`?
Unfortunately id can be both a string or a number according to LSP specs
therefore we normalize both cases into a string.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
