beanz added a comment. Just want to bring an IRC conversation that I had with @phosek into the proper code review.
This patch is great as-is, but if we want to extend this to Darwin there are some problems because of how Darwin handles triples. Specifically Darwin has multiple potentially valid triples that can mean the same things. For example x86_64-apple-darwin17.7.0 and x86_64-apple-macos10.13.6 are 100% interchangeable (even down to referring to the same OS version). Things get even stranger when you start talking about the -simulator triples... This means that to support this in Darwin we need to support iterating over a list of triples. We also probably want to cache that list so that we don't run `getVFS().exists(...)` over and over again. @phosek said on IRC he will update the patch to reflect our conversation. Thanks @phosek for all the great work on this! Repository: rC Clang https://reviews.llvm.org/D50547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
