hokein added a subscriber: deannagarcia. hokein added a comment. Your patch seems have some comments unaddressed but you marked done.
About the abseil matcher stuff, you and @deannagarcia have an overlap, maybe just wait for https://reviews.llvm.org/D50580 to submit, and reuse the matcher in this patch? ================ Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24 + auto &SourceManager = Finder->getASTContext().getSourceManager(); + SourceLocation loc = Node.getBeginLoc(); + if (loc.isInvalid()) ---------------- nit: loc => Loc https://reviews.llvm.org/D50542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
