NoQ added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:419
+      case CK_LValueBitCast:
+      case CK_FixedPointCast: {
         state =
----------------
a.sidorin wrote:
> Should we consider this construction as unsupported rather than supported as 
> a normal cast?
Uhm, this code seems to be held together by magic. We squeeze all sorts of 
casts (eg., float casts) into a subroutine that deals with casts of //lvalues// 
(!?) Fortunately, it dissolves into `SValBuilder::evalCast()` pretty quickly, 
so we don't really get punished for that. So it's not this patch's fault but 
our technical debt. I guess this change on its own doesn't make things worse, 
so i'm ok with it.


Repository:
  rC Clang

https://reviews.llvm.org/D50616



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to