davidxl added a comment.

thanks for working on this.

Can you split the patch into two? One for sample PGO and one for 
instrumentation.

In particular, I don't see much need to do this for instrumentation based PGO, 
but we can defer discussion on that once the patch is split.


https://reviews.llvm.org/D51240



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D51240: A... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... David Li via Phabricator via cfe-commits
    • [PATCH] D512... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D512... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D512... David Li via Phabricator via cfe-commits
    • [PATCH] D512... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to