kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Dex is now mature enough to be used as the default static index. This patch performs the switch but introduces a hidden flag to allow users fallback to Mem in case something happens. https://reviews.llvm.org/D51352 Files: clang-tools-extra/clangd/tool/ClangdMain.cpp Index: clang-tools-extra/clangd/tool/ClangdMain.cpp =================================================================== --- clang-tools-extra/clangd/tool/ClangdMain.cpp +++ clang-tools-extra/clangd/tool/ClangdMain.cpp @@ -30,8 +30,8 @@ using namespace clang::clangd; static llvm::cl::opt<bool> - UseDex("use-dex-index", - llvm::cl::desc("Use experimental Dex static index."), + UseMem("use-mem", + llvm::cl::desc("Use Mem for static index."), llvm::cl::init(false), llvm::cl::Hidden); namespace { @@ -52,8 +52,8 @@ for (auto Sym : Slab) SymsBuilder.insert(Sym); - return UseDex ? dex::DexIndex::build(std::move(SymsBuilder).build()) - : MemIndex::build(std::move(SymsBuilder).build()); + return UseMem ? MemIndex::build(std::move(SymsBuilder).build()) + : dex::DexIndex::build(std::move(SymsBuilder).build()); } } // namespace
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp =================================================================== --- clang-tools-extra/clangd/tool/ClangdMain.cpp +++ clang-tools-extra/clangd/tool/ClangdMain.cpp @@ -30,8 +30,8 @@ using namespace clang::clangd; static llvm::cl::opt<bool> - UseDex("use-dex-index", - llvm::cl::desc("Use experimental Dex static index."), + UseMem("use-mem", + llvm::cl::desc("Use Mem for static index."), llvm::cl::init(false), llvm::cl::Hidden); namespace { @@ -52,8 +52,8 @@ for (auto Sym : Slab) SymsBuilder.insert(Sym); - return UseDex ? dex::DexIndex::build(std::move(SymsBuilder).build()) - : MemIndex::build(std::move(SymsBuilder).build()); + return UseMem ? MemIndex::build(std::move(SymsBuilder).build()) + : dex::DexIndex::build(std::move(SymsBuilder).build()); } } // namespace
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits