Szelethus abandoned this revision. Szelethus added a comment. In https://reviews.llvm.org/D49986#1192798, @Szelethus wrote:
> In https://reviews.llvm.org/D49985#1181568, @NoQ wrote: > > > In https://reviews.llvm.org/D49985#1181564, @dblaikie wrote: > > > > > It looks like concat orders the arguments in the same way that the output > > > would be (so concat(X, list) produces [X, list]) - so preserving that > > > argument order seems like it improves/retains readability compared to > > > switching them around so 'concat(list, X)' produces '[X, list]'. > > > > > > Yeah, i guess that might have been the motivation behind such > > inconsistency. I'll be fine with fixing the order for other data structures. > > > @NoQ Have your views changed about this patch? Shall I abandon it? I've decided to do so after https://reviews.llvm.org/rL340824. Repository: rC Clang https://reviews.llvm.org/D49986 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
