JonasToth added a comment. In https://reviews.llvm.org/D48714#1216989, @lebedev.ri wrote:
> In https://reviews.llvm.org/D48714#1216537, @JonasToth wrote: > > > I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with > > his revision. It fails the test, i think there is an inconsistency or so in > > the check-clang-tidy script. I will try to figure out whats the issue. > > > So what was the issue? Do you get the same results if you undo the > https://reviews.llvm.org/D51381 and `s/CHECK-MESSAGES/CHECK-NOTES/`? You are right that replacing all of it with `CHECK-NOTES` works as well. `FileCheck` is run twice if you have `FIXMES` as well. Having another run for the notes is consistent with how it worked before. If we go for the catch-all-with-one approach it might be a good idea to ensure that only one of `CHECK-MESSAGES` or `CHECK-NOTES` is present in the file and adjust the check_clang_tidy.py script a little. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
