ioeric added inline comments.
================ Comment at: clang-tools-extra/docs/clang-rename.rst:140 + +:program:`clangd <https://clang.llvm.org/extra/clangd.html>`_ uses +:program:`clang-rename` infrastructure to handle renaming requests. Currently, ---------------- nit: `clangd *shares* the renaming infrastructure of clang-rename...` ================ Comment at: clang-tools-extra/docs/clang-rename.rst:141 +:program:`clangd <https://clang.llvm.org/extra/clangd.html>`_ uses +:program:`clang-rename` infrastructure to handle renaming requests. Currently, +it only supports renaming symbol within a single file, but in the future it will ---------------- ilya-biryukov wrote: > `handle renaming requests` seems to assume some familiarity with LSP. Maybe > rephrase? > Currently it only supports renaming symbol within a single file, but in the > future it will have much better support than the standalone tool. This seems clangd specific and can easily get outdated when the support is actually added in clangd. Consider moving it to clangd's documentation if we do want to advertise `rename` at this point? https://reviews.llvm.org/D51292 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
