arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+ CC1Args.append({"-fvisibility", "hidden"});
}
----------------
yaxunl wrote:
> arsenm wrote:
> > We should probably start subclassing the HIP toolchain from AMDGPU and
> > share more of this
> I'd like to defer the refactoring of HIP and AMDGPU toolchain to another
> patch. There are stuff in HIP toolchain which should go to AMDGPU toolchain.
> We need to sort out the relation between HIP and AMDGPU toolchain in that
> patch.
>
Yes
https://reviews.llvm.org/D51434
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
