kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/index/dex/Token.h:54
Scope,
+ /// Path to symbol declaration.
+ ///
----------------
ioeric wrote:
> As this is called `Path`, I'd try to decouple it from URIs, so that we don't
> need special handling of `scheme` etc in the implementation. We might want to
> canonicalize URI to "path" like `/file:/path/to/something/` so that we could
> simply treat it as normal paths, and the token could potentially handle
> actual actual file paths.
Should probably rename it to URI and be more explicit about its nature.
https://reviews.llvm.org/D51481
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
