atanasyan added a comment.

Could you please include more context to patches sent for review?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface



================
Comment at: lib/Driver/ToolChains/Linux.cpp:46
       TargetTriple.getEnvironment();
+  llvm::Triple::SubArchType TargetSubArch = TargetTriple.getSubArch();
   bool IsAndroid = TargetTriple.isAndroid();
----------------
Maybe use `bool IsR6` to make the following expressions shorter?


================
Comment at: lib/Driver/ToolChains/Linux.cpp:111
+        (TargetSubArch == llvm::Triple::MipsSubArch_r6) ? "mipsisa32"
+                                                       : "mips";
+    if (D.getVFS().exists(SysRoot + "/lib/" + MipsCpu + "-linux-gnu"))
----------------
clang-format these lines


Repository:
  rC Clang

https://reviews.llvm.org/D50850



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to