AlexeySachkov added inline comments.
================ Comment at: include/clang/Basic/OpenCLExtensionTypes.def:1 +//===-- OpenCLExtensionTypes.def - Metadata about BuiltinTypes ------*- C++ -*-===// +// ---------------- Anastasia wrote: > I am confused about the purpose of this file. Is it supposed to contain intel > extension specific types or generally OpenCL types? It is supposed to contain any opaque types from any OpenCL extension ================ Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27 + +INTEL_SGAVC_TYPE(mce_payload_t, McePayload) +INTEL_SGAVC_TYPE(ime_payload_t, ImePayload) ---------------- Anastasia wrote: > From the specification of this extension I can't quite see if these types > have to be in Clang instead of the header. Can you please elaborate on any > example where it wouldn't be possible for this type to be declared in the > header using the technique explained in: > https://clang.llvm.org/docs/UsersManual.html#opencl-extensions We cannot define these types in header because their layout is not defined in specification, i.e. all of these types are opaque Repository: rC Clang https://reviews.llvm.org/D51484 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
