jfb added inline comments.

================
Comment at: lib/Sema/SemaChecking.cpp:10974
+  if (E->IgnoreParenImpCasts()->getType()->isAtomicType())
+    return;
   CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
----------------
rjmccall wrote:
> Can you explain this one?
It would produce duplicate warnings of `!`, `&&`, `||`, and condition for `? 
:`. Bool-like conversion is a special case of implicit conversion, which we 
already check elsewhere.


Repository:
  rC Clang

https://reviews.llvm.org/D51084



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to