lewissbaker added inline comments.
================ Comment at: test/std/experimental/task/sync_wait.hpp:36-37 + __isSet_ = true; + } + __cv_.notify_all(); + } ---------------- The call to `notify_all()` needs to be inside the lock. Otherwise, it's possible the waiting thread may see the write to `__isSet_` inside `wait()` below and return, destroying the `condition_variable` before `__cv_.notify_all()` call completes. https://reviews.llvm.org/D46140 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
