sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/ClangdLSPServer.cpp:108 + if (Params.capabilities.textDocument.completion.completionItemKind) + for (CompletionItemKind Kind : *Params.capabilities.textDocument.completion + .completionItemKind->valueSet) ---------------- also check if valueSet is None before dereferencing it? ================ Comment at: clangd/Protocol.h:265 +}; + +bool fromJSON(const llvm::json::Value &, CompletionItemKind &); ---------------- (nit: drop blank line for consistency) ================ Comment at: clangd/Protocol.h:274 +}; +bool fromJSON(const llvm::json::Value &, std::vector<CompletionItemKind> &); +bool fromJSON(const llvm::json::Value &, CompletionItemKindCapabilities &); ---------------- wasn't obvious why this is necessary vs the default... Maybe add a comment `// Discards unknown kinds` (and to SymbolKind)? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52616 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits