steveire marked 2 inline comments as done. steveire added a comment. @aaron.ballman Happy to add a note to the docs, but your request leaves me wondering where?
AFAIK, the fact that `clang-tidy` wasn't built at all when using `CLANG_ENABLE_STATIC_ANALYZER` is not documented, so I can't just update that. Also AFAIK, other build switches don't have such exhaustive documentation that they mention things like this. Is this so important to document that it needs to be done here? I don't think it is that important. I think it's just a bug that clang-tidy is entirely excluded from the build when not using `CLANG_ENABLE_STATIC_ANALYZER`. This commit fixes that bug, so it would be great to get a LGTM from someone/anyone so I can commit it.. This patch definitely does not need as much discussion as it is getting. It's just enabling the build of clang-tidy when not building the static analyzer. ================ Comment at: clang-tidy/CMakeLists.txt:29 +if(CLANG_ENABLE_STATIC_ANALYZER) +target_link_libraries(clangTidy PRIVATE + clangStaticAnalyzerCore ---------------- aaron.ballman wrote: > Indentation looks off here, same below. Yes, I used the same indentation (none) as the previous code. I can indent this as you wish. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
