ygao added a comment. > What I would suggest is:
> > Check that this test fails at least on windows with your patch > > reverted. If so, commit it. BTW, don't you need to drop the "| > FileCheck" to cause a crash? Hmm, even with the pipe removed, I still have difficulty reproducing the crash within lit. I was doing: C:\llvm\build>python ..\llvm\utils\lit\lit.py -v --no-progress-bar --param build_mode=Release tools\clang\test\Preprocessor\macro.c But the test is passing. And the run line is simply: // RUN: %clang_cc1 -E -x c %s And, if I use the RUN line directly on a command-prompt, the test crashes as expected. http://reviews.llvm.org/D15705 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
