george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed.
+1, I think this is a great addition! BTW in theory it should be possible to go wild on compile-time programming, and generate the entire description string at compile time, but it does not seem to be worth it. Also, you seem to be missing tests (at least to verify that the code does not crash). Also, that's a lot of code for printing options. I understand it's hard to do wrapping properly, but I'm not sure whether it makes sense for half of the `CheckerRegistration.cpp` file to be doing option wrapping for help printing. Could you look into simpler alternatives? (or if your wrapping printer is indeed indispensable, maybe it should go somewhere into `llvm/lib/Support/format`?) I am not sure what would be a better solution here, maybe it's already possible to write something much smaller using components from `lib/Support`. Repository: rC Clang https://reviews.llvm.org/D53296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
