george.karpenkov added a comment. OK that makes sense to me, just let's be careful not to crash in places where we weren't crashing before.
================ Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354 +StringRef AnalyzerOptions::getOptionAsString(Optional<StringRef> &V, + StringRef Name, ---------------- I'm slightly confused, where is this function called? Same for the function above? https://reviews.llvm.org/D53274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits