NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think this is awesome o_o
================
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:70-71
+
+/// Controls the high-level analyzer mode, which influences the default
+/// settings for some of the lower-level config options (such as IPAMode).
+ANALYZER_OPTION(
----------------
I think it's unnecessary to duplicate the --help text in comments.
================
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:128-135
+/// Describes the kinds for high-level analyzer mode.
+enum UserModeKind {
+ /// Perform shallow but fast analyzes.
+ UMK_Shallow = 1,
+
+ /// Perform deep analyzes.
+ UMK_Deep = 2
----------------
Xcode uses shallow mode when you tick the checkbox to run static analyzer
during normal build, so that not to slow down builds too much.
> rewriting the function generating macro
This seems indeed fancier because it makes everything constexpr, which opens up
more possibilities. But i don't see any actual possibilities that it opens up.
I guess we can always change it when it becomes necessary. Also it's probably
better to make a separate macro for options that have different default values
in shallow and deep modes, so that not to duplicate every default value twice.
https://reviews.llvm.org/D53277
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
