hubert.reinterpretcast added inline comments.
================ Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); ---------------- wuzish wrote: > hubert.reinterpretcast wrote: > > `__v4sc` is suspicious. The most consistent naming I have seen is `v16i8`, > > `v16u8`, `v8i16`, ... > > Do we need the double underscores? > > > Because it's generic gcc vector type instead of altivec type so I choose the > naming style. The naming style from `clang/lib/Headers/avxintrin.h` would still say that the `__v4sc` here should be `__v16qi`. Repository: rC Clang https://reviews.llvm.org/D53417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
