aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some small nits.
================
Comment at: clang/docs/LanguageExtensions.rst:2666
- #pragma clang attribute push(__attribute__((annotate("custom"))), apply_to =
function)
+ #pragma clang attribute push (__attribute__((annotate("custom"))), apply_to
= function)
----------------
The whitespace changes here are not needed as part of this patch, right? (It's
just changing the style of the docs?)
================
Comment at: clang/lib/Parse/ParsePragma.cpp:3149
else {
- PP.Diag(Tok.getLocation(), diag::err_pragma_attribute_invalid_argument)
- << PP.getSpelling(Tok);
- return;
+ const auto *II = Tok.getIdentifierInfo();
+ if (II->isStr("push"))
----------------
I'd prefer dropping the `auto` here.
https://reviews.llvm.org/D53621
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
