Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:22
+ ast_matchers::MatchFinder *Finder) {
+ // For the arithmetic calls, we match only the uses of the templated
operators
+ // where the template parameter is not a built-in type. This means the
----------------
Please add check for C++. See other Abseil checks code as example.
================
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:136
+
+ auto SourceRange = Lexer::makeFileCharRange(
+ CharSourceRange::getTokenRange(ArgExpr->getSourceRange()),
----------------
Please don't use auto, since return type is not obvious.
================
Comment at: docs/ReleaseNotes.rst:70
+- New :doc:`abseil-upgrade-duration-conversions
+ <clang-tidy/checks/abseil-upgrade-duration-conversions>` check.
----------------
Please sort new checks list alphabetically.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
