lebedev.ri added inline comments.
================ Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:84 "cppcoreguidelines-c-copy-assignment-signature"); + CheckFactories.registerCheck<modernize::AvoidCArraysCheck>( + "cppcoreguidelines-avoid-c-arrays"); ---------------- JonasToth wrote: > please conserve the alphabetical order here Sorted all the `CheckFactories.registerCheck<>();` lines. ================ Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:44 + unless(anyOf(hasParent(varDecl(isExternC())), + hasAncestor(functionDecl(isExternC()))))) + .bind("typeloc"), ---------------- JonasToth wrote: > What about struct-decls that are externC? Hm, what is a `struct-decl`? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits