rnk added a comment. In https://reviews.llvm.org/D53541#1282764, @mgrang wrote:
> Updated the patch with the following changes: > > 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. For aarch64 > windows, the parent fp is always passed in x1. So we don't need a separate > instrinsic to recover the fp. What about the three stack pointer case of stack realignment plus a dynamic alloca? Typically this is the case where recoverfp is necessary. ================ Comment at: lib/Driver/ToolChains/Clang.cpp:471 + } + EH |= SEHExceptions; + ---------------- efriedma wrote: > I'm suspicious about adding a new default for AArch64 specifically; why do we > need this if x86-64 doesn't? Yeah, -cc1 -fexceptions really means "should I emit destructor cleanups", and SEH doesn't require that at all. https://reviews.llvm.org/D53541 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
