hokein marked 3 inline comments as done. ================ Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:4 @@ +3,3 @@ +int f() { +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'f' defined in a header file; +// CHECK-FIXES: inline int f() { ---------------- alexfh wrote: > Please specify each distinct warning message (in your case, there are two of > them) completely (including the check name) once. Having it in the test (just > once) is useful to verify that the message is formatted correctly (in your > case, there's no space after the ';', for example). Didn't notice it. Done (also add a space after ";").
http://reviews.llvm.org/D15710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits