hokein added inline comments.
================
Comment at: lib/Tooling/AllTUsExecution.cpp:120
for (std::string File : Files) {
+ if (Filter.getNumOccurrences() != 0 && !RegexFilter.match(File))
+ continue;
----------------
ioeric wrote:
> > `Filter.getNumOccurrences() != 0 `
> Would this work if `Filter` is set grammatically? Although it's not exposed
> now, it might make more sense to check `Filter != ".*"`.
Yes, getNumOccurrences returns non-zero only when the flag is set by the
command line.
```
clang-tool -executor=all-TUs . # => getNumOccurrences() == 0
clang-tool -executor=all-TUs -filter="xx" . # > getNumOccurrences() != 0
```
Repository:
rC Clang
https://reviews.llvm.org/D54092
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
