mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: bindings/python/clang/cindex.py:133 +except AttributeError: + def fspath(string): + return string ---------------- Optionally: this is now a little bit nitpick but could you use a different variable name (e.g. commonly used elsewhere `x`)? This could be a little bit confusing with Python's `string` module. https://reviews.llvm.org/D54120 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
