sthibaul marked 3 inline comments as done.
sthibaul added a comment.

I commented one of them, and will fix the rest.



================
Comment at: lib/Driver/ToolChains/Hurd.cpp:36
+  // clever.
+  switch (TargetTriple.getArch()) {
+  default:
----------------
kristina wrote:
> Does this need a switch? Wouldn't an `if` be sufficient?
An if would work, yes, it's just to make it easily extensible for future cases, 
just like the getMultiarchTriple function in Linux.cpp


Repository:
  rC Clang

https://reviews.llvm.org/D54379



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to