steveire added inline comments.
================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77
+ internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) {
+ auto K = ast_type_traits::ASTNodeKind::getFromNodeKind<
+ typename
ast_matchers::internal::VariadicAllOfMatcher<ResultT>::Type>();
----------------
aaron.ballman wrote:
> Mildly not keen on the use of `auto` here. It's a factory function, so it
> kind of names the resulting type, but it also looks like the type will be
> `ast_matchers::internal::VariadicAllOfMatcher<ResultT>::Type` from the
> template argument, which is incorrect.
There is no reason to assume that taking a template argument means that type is
result.
The method is `getFrom` which decreases the ambiguity still further.
Spelling out the type doesn't add anything useful. This should be ok.
Repository:
rC Clang
https://reviews.llvm.org/D54405
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
