asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed.
Thanks for the patch Lewis. Could I please request the following changes: - It would be handy to link to https://gcc.gnu.org/onlinedocs/gccint/Machine-Constraints.html in the patch summary, so people can easily double-check the constraint definitions for themselves - Could you add tests for values outside of the expected range. AArch64 and X86 do this in test/Sema/inline-asm-validate-{aarch64,x86}.c - It would be worth expanding riscv-inline-asm.c to provide simple sanity checks for "m" and "r" Repository: rC Clang https://reviews.llvm.org/D54091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
