arphaman added a comment.

I don't think we want to move the logic to add a libc++ path to the driver. 
`-cc1` with `-resource-dir` and `-stdlib=libc++` should still work as before. 
In this case the previous patch is better, except it should not set 
`InstalledDir` except when needed (e.g. for tooling when working with a CDB 
that has an absolute path to the compiler), so when `InstalledDir` is empty it 
should fallback to the current logic in `InitHeaderSearch.cpp`. That should 
solve the issues we had.


Repository:
  rC Clang

https://reviews.llvm.org/D54630



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to