sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
You may want to add a FIXME in SymbolIndex to include opaque type in fuzzyfind
request.
================
Comment at: clangd/CodeComplete.cpp:1504
+ if (PreferredType)
+ Relevance.HadContextType |= true;
----------------
`|=` true is more traditionally known as `= true` :-)
(and below)
================
Comment at: clangd/Quality.cpp:418
+ OS << formatv("\tSema provided preferred type: {0}\n", S.HadContextType);
+ OS << formatv("\tSymbol had type: {0}\n", S.HadSymbolType);
----------------
Consider combining these: "Type matched preferred: {0} (Context type: {1},
Symbol type: {2}"
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52276/new/
https://reviews.llvm.org/D52276
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
