ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments.
================ Comment at: clangd/index/Index.h:283 + /// Type of the symbol, used for scoring purposes. + llvm::StringRef Type; ---------------- sammccall wrote: > either call this OpaqueType or point at in in the comment? > > I'd put this below the `ReturnType` string too, it seems out of place here. > But up to you. - Added a comment. OpaqueType would clash with the type name, something I'd prefer to avoid. - Moved to live after `ReturnType`. I initially thought it'd be nice to keep them apart, since `ReturnType` is for showing it to the users and `Type` is for scoring. Now that I think about it does not look like a good idea, since keeping them apart means the user might read the comment for one of them, but not the other and end up inferring the other one on their own. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52274/new/ https://reviews.llvm.org/D52274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
