Szelethus added a comment. > @george.karpenkov Matching macros is a very non-trivial job, how would you > feel if we shipped this patch as-is, and maybe leave a TODO about adding > macro `assert`s down the line?
The only solution I saw in clang-tidy was to match binary expressions as a heuristic, and check whether they are inside a macro named assert. That is hacky at best, any objection against the current state of this patch? I'm planning to evaluate the checker in a variety of projects after this one, see how things are looking, and push it out of alpha. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
