yvvan added a comment.

I've realized that this patch covers too much stuff outside of clang and I have 
no idea how bad is to not memory map it.

"My hope is that we can get rid of this flag some day" - i'm not sure it's 
possible. For that we need some concept of user and system files in llvm 
similar to clang::SrcMgr::CharacteristicKind. But we can probably make an 
adapter for the MemoryBuffer in clang which will do the work at least in clang 
case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to