ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:204
+ EXPECT_EQ(ShardSource->Sources->size(), 2U); // A.cc, A.h
+ EXPECT_THAT(
+ ShardSource->Sources->lookup("unittest:///root/A.cc").DirectIncludes,
----------------
NIT: maybe also check the hash of `A.cc` is initialized (the value doesn't
matter, probably, just to make sure it's not 0)?
================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:212
+ EXPECT_TRUE(ShardHeader->Sources);
+ EXPECT_EQ(ShardHeader->Sources->size(), 2U); // A.h B.h
+ EXPECT_THAT(
----------------
NIT: maybe add a comma? `A.h, B.h`
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55062/new/
https://reviews.llvm.org/D55062
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
