ABataev added a comment. In D55395#1322431 <https://reviews.llvm.org/D55395#1322431>, @rsmith wrote:
> In D55395#1322244 <https://reviews.llvm.org/D55395#1322244>, @ABataev wrote: > > > This is wrong, the original implementation is correct and should not be > > changed. > > > The original implementation looks pretty clearly wrong to me, but I think > this is wrong too. It looks like what was intended here was probably to label > the two children as "combiner" and "initializer" respectively. As-is, the > "combiner" text on the `OMPDeclareReductionDecl` line means nothing at all. Oh yes, agree. Still must be reworked. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55395/new/ https://reviews.llvm.org/D55395 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
