mgorny marked an inline comment as done. mgorny added inline comments.
================ Comment at: test/lit.cfg.py:100 config.available_features.add('gnutar') - tar_version.wait() ---------------- ruiu wrote: > Maybe a silly question, but is this OK to remove this line? Yes. [[ https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate | communicate() ]] waits on the process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55443/new/ https://reviews.llvm.org/D55443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits