aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

Missing test cases.



================
Comment at: clang/lib/Sema/SemaType.cpp:5747
+static bool BuildAddressSpaceIndex(LangAS &ASIdx, const Expr *AddrSpace,
+                                   SourceLocation AttrLoc, Sema &S) {
   if (!AddrSpace->isValueDependent()) {
----------------
I think we usually pass the `Sema` argument first in these helper methods.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55447/new/

https://reviews.llvm.org/D55447



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to